feat(filters): add Date & Point “is” for private and public query #470
Open
0xTaneja wants to merge 3 commits intographprotocol:mainfrom
Open
feat(filters): add Date & Point “is” for private and public query #4700xTaneja wants to merge 3 commits intographprotocol:mainfrom
0xTaneja wants to merge 3 commits intographprotocol:mainfrom
Conversation
Collaborator
|
hey, will review this one end of the week or early next one. Currently only focusing on bug fixes and necessary features for the ETHGlobal Hackathon |
Contributor
Author
|
okay great , take your time !! @nikgraf |
Contributor
Author
|
@nikgraf , would love to take feedback on this one , when you have time !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Date and Point
isvalue filters to both private and public queries.fixes #440
Changes Made :-
for private query,
In
types.ts, I extendedEntityFieldFilter<T>to supportDateandReadonlyArray<number>.Another change which i made was in ,
findMany.ts, evaluated Date viagetTime()and Point via [x, y] deep equality.for public query from what i understood from the codebase was that useQueryPublic already passes $filter and selects time/point, so no extra wiring needed.
edited
translate-filter-to-graphql.ts-Date →
time: { is: Graph.serializeDate(date) }Point →
point: { is: Graph.serializePoint([x, y]) }Added a few tests on public & private queries
No breaking changes. Only adds filter capabilities.
Applies only when users provide Date/Point filters.